Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only disable page-index-reset for edits #3160

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 7, 2024

A more nuanced follow-up to #3158, which rightly prevented a reset of the current page index when a row is edited. A sad byproduct was that the table no longer jumps back to the first page when column filters/sorts are applied or changed. This pr restores that preferred behavior.


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend goal: ReviewEntries Size: S Small sized issue labels Jun 7, 2024
@imnasnainaec imnasnainaec self-assigned this Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.57%. Comparing base (fa18e58) to head (65ae0b9).
Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
...c/goals/ReviewEntries/ReviewEntriesTable/index.tsx 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3160      +/-   ##
==========================================
+ Coverage   74.55%   74.57%   +0.01%     
==========================================
  Files         279      279              
  Lines       10687    10694       +7     
  Branches     1288     1288              
==========================================
+ Hits         7968     7975       +7     
+ Misses       2355     2354       -1     
- Partials      364      365       +1     
Flag Coverage Δ
backend 83.79% <ø> (ø)
frontend 66.49% <33.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 13, 2024 21:29
@imnasnainaec imnasnainaec merged commit 9feb899 into master Aug 13, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the autoResetPageIndexRef branch August 13, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend goal: ReviewEntries Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants