-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only disable page-index-reset for edits #3160
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3160 +/- ##
==========================================
+ Coverage 74.55% 74.57% +0.01%
==========================================
Files 279 279
Lines 10687 10694 +7
Branches 1288 1288
==========================================
+ Hits 7968 7975 +7
+ Misses 2355 2354 -1
- Partials 364 365 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
A more nuanced follow-up to #3158, which rightly prevented a reset of the current page index when a row is edited. A sad byproduct was that the table no longer jumps back to the first page when column filters/sorts are applied or changed. This pr restores that preferred behavior.
This change is