Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary [FromForm] baggage and fix axios issue #3176

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 24, 2024

Resolves #1930


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working backend .NET Pull requests that update .net code labels Jun 24, 2024
@imnasnainaec imnasnainaec self-assigned this Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.14%. Comparing base (e8a7106) to head (7f66031).

Files Patch % Lines
Backend/Controllers/LiftController.cs 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3176      +/-   ##
==========================================
+ Coverage   75.10%   75.14%   +0.04%     
==========================================
  Files         275      275              
  Lines       10423    10414       -9     
  Branches     1230     1231       +1     
==========================================
- Hits         7828     7826       -2     
+ Misses       2235     2231       -4     
+ Partials      360      357       -3     
Flag Coverage Δ
backend 84.26% <69.23%> (+0.11%) ⬆️
frontend 66.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as draft June 25, 2024 12:20
@imnasnainaec imnasnainaec changed the title Add missing filename param Remove unnecessary [FromForm] baggage Jun 25, 2024
@imnasnainaec imnasnainaec marked this pull request as ready for review June 26, 2024 12:48
@imnasnainaec imnasnainaec changed the title Remove unnecessary [FromForm] baggage Remove unnecessary [FromForm] baggage and fix axios issue Jun 26, 2024
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 8 files at r1, 18 of 18 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@imnasnainaec imnasnainaec merged commit e8c1233 into master Jun 26, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the filename branch June 26, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio backend bug Something isn't working frontend .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading to axios version 1.x.x breaks audio recording
2 participants