Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CreateProject] Improve empty name handling #3184

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 27, 2024

Resolves #3173

To review, experiment in the Create Project box (on the first page you see when you login). Add and remove content from different fields (including the file upload), observing (A) when the warning text appears/disappears on the "Project Name" field, and (B) when the Submit button is disabled/enabled. Does the behavior feel intuitive, sensible?


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend project labels Jun 27, 2024
@imnasnainaec imnasnainaec self-assigned this Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.76%. Comparing base (85c12dd) to head (4c0de98).
Report is 45 commits behind head on master.

Files with missing lines Patch % Lines
src/components/ProjectScreen/CreateProject.tsx 50.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3184      +/-   ##
==========================================
- Coverage   74.76%   74.76%   -0.01%     
==========================================
  Files         277      277              
  Lines       10636    10635       -1     
  Branches     1276     1278       +2     
==========================================
- Hits         7952     7951       -1     
  Misses       2319     2319              
  Partials      365      365              
Flag Coverage Δ
backend 83.84% <ø> (ø)
frontend 66.73% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) July 9, 2024 14:14
@imnasnainaec imnasnainaec merged commit 0258f37 into master Jul 9, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the create-proj-name-warn branch July 9, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create project doesn't warn about empty name unless you've clicked in the name field
2 participants