Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear spell-checker if new lang has no dictionary #3185

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 27, 2024

Fixes #3183


This change is Reviewable

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.59%. Comparing base (9feb899) to head (9bb8425).
Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
src/utilities/spellChecker.ts 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3185      +/-   ##
==========================================
- Coverage   74.61%   74.59%   -0.03%     
==========================================
  Files         279      279              
  Lines       10694    10697       +3     
  Branches     1288     1289       +1     
==========================================
  Hits         7979     7979              
- Misses       2351     2354       +3     
  Partials      364      364              
Flag Coverage Δ
backend 83.79% <ø> (-0.09%) ⬇️
frontend 66.53% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 13, 2024 21:37
@imnasnainaec imnasnainaec merged commit 5d7eee8 into master Aug 13, 2024
18 of 19 checks passed
@imnasnainaec imnasnainaec deleted the gloss-dict-clear branch August 13, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching to analysis language with no spell-check dictionary doesn't disable suggestions
2 participants