Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retract #3161 due to broken placement styles #3188

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 28, 2024

#3161 used sx color functions with no regard for different size/margin/placement handling between style and sx. As a consequence, the announcement banner and the loading button spinning wheel (and possibly other things) were way out of place:

Screenshot 2024-06-28 144047


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend labels Jun 28, 2024
@imnasnainaec imnasnainaec self-assigned this Jun 28, 2024
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.13%. Comparing base (2e5d278) to head (4753f08).

Files Patch % Lines
src/components/ProjectExport/DownloadButton.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3188      +/-   ##
==========================================
+ Coverage   75.11%   75.13%   +0.02%     
==========================================
  Files         275      275              
  Lines       10422    10413       -9     
  Branches     1232     1231       -1     
==========================================
- Hits         7828     7824       -4     
+ Misses       2236     2231       -5     
  Partials      358      358              
Flag Coverage Δ
backend 84.24% <ø> (+0.06%) ⬆️
frontend 66.96% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 3f8db49 into master Jun 28, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the theme-retract branch June 28, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants