Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReviewEntries] Prevent table flickering with parts of speech #3217

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 1, 2024

Fixes #3177, which appeared in #3156.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.91%. Comparing base (755fbe0) to head (0123df4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3217      +/-   ##
==========================================
+ Coverage   74.86%   74.91%   +0.05%     
==========================================
  Files         277      277              
  Lines       10622    10622              
  Branches     1270     1270              
==========================================
+ Hits         7952     7958       +6     
+ Misses       2307     2303       -4     
+ Partials      363      361       -2     
Flag Coverage Δ
backend 84.04% <ø> (+0.12%) ⬆️
frontend 66.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 157753b into master Jul 1, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the anti-flicker branch July 1, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ReviewEntriesTable] Multiline part-of-speech cells can cause flickering
2 participants