[README] Remove unhelpful action badges #3225
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3225 +/- ##
==========================================
+ Coverage 74.80% 74.84% +0.04%
==========================================
Files 277 277
Lines 10635 10635
Branches 1278 1278
==========================================
+ Hits 7955 7960 +5
+ Misses 2316 2312 -4
+ Partials 364 363 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Hmm. I missed adding that badge. Is that one that we want to be there? Could it invite the wrong kind of attention?
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
imnasnainaec
changed the title
There was a problem hiding this comment.
Reasonable questions. On reflection, I don't think the action badges were of any particular use, especially since at least one of them didn't even show failing when the action failed. So I've completely removed that row.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @imnasnainaec and @jasonleenaylor)
imnasnainaec
changed the title
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Before, the links were all to the same general actions page and the scorecard badge always said passing even when it failed:
After, the links go to specific relevant actions and the unhelpful action badges are removed:
This change is