Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] Add 'Getting Started' step to load sem doms #3230

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 5, 2024

Resolves #3159

To review this pr, check out the README in this branch:

  • Does the placement of the new step make sense in the README?
  • Is the instruction clear, concise, correct, and without spelling/grammar errors?
  • Do the links work?

This change is Reviewable

@imnasnainaec imnasnainaec added the documentation Improvements or additions to documentation label Jul 5, 2024
@imnasnainaec imnasnainaec self-assigned this Jul 5, 2024
@imnasnainaec imnasnainaec requested a review from andracc July 5, 2024 19:13
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (457eafe) to head (2c2aa71).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3230      +/-   ##
==========================================
- Coverage   74.87%   74.82%   -0.05%     
==========================================
  Files         277      277              
  Lines       10622    10622              
  Branches     1270     1270              
==========================================
- Hits         7953     7948       -5     
- Misses       2306     2310       +4     
- Partials      363      364       +1     
Flag Coverage Δ
backend 83.84% <ø> (-0.11%) ⬇️
frontend 66.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 12f00ab into master Jul 5, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the readme-get-started branch July 5, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve instructions for importing semantic domains
2 participants