Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't make button text all-caps #3231

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Don't make button text all-caps #3231

merged 5 commits into from
Aug 14, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 5, 2024

Resolves #3069

(User Guide screen shots that show all-caps buttons can stick around until they need to be replaced for other reasons.)


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.63%. Comparing base (25c5298) to head (06f6e2f).
Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3231      +/-   ##
==========================================
+ Coverage   66.53%   74.63%   +8.10%     
==========================================
  Files         232      279      +47     
  Lines        5704    10697    +4993     
  Branches      689     1289     +600     
==========================================
+ Hits         3795     7984    +4189     
- Misses       1691     2351     +660     
- Partials      218      362     +144     
Flag Coverage Δ
backend 83.89% <ø> (?)
frontend 66.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 14, 2024 12:17
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 7e2337b into master Aug 14, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the buttons-not-all-caps branch August 14, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop making button text all-caps
2 participants