Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UserGuide > Projects > Semantic Domains] Update example; Add images #3248

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 12, 2024

To test the User Guide in development: https://github.com/sillsdev/TheCombine?tab=readme-ov-file#user-guide

Screenshot 2024-07-12 141602
Screenshot 2024-07-12 142941
Screenshot 2024-07-12 141652

This change is Reviewable

@imnasnainaec imnasnainaec added the documentation Improvements or additions to documentation label Jul 12, 2024
@imnasnainaec imnasnainaec self-assigned this Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (6f7e5d3) to head (fe19636).
Report is 28 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3248   +/-   ##
=======================================
  Coverage   74.62%   74.62%           
=======================================
  Files         279      279           
  Lines       10697    10697           
  Branches     1289     1289           
=======================================
  Hits         7983     7983           
  Misses       2351     2351           
  Partials      363      363           
Flag Coverage Δ
backend 83.87% <ø> (ø)
frontend 66.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review July 26, 2024 18:47
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 8 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 15, 2024 12:56
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 87e875b into master Aug 15, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the user-guide-project-sem-doms branch August 15, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants