Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataEntryTable] Distinguish between new and updated words #3307

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 14, 2024

Fixes #3262


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.62%. Comparing base (559a2de) to head (07e4415).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
src/components/DataEntry/DataEntryTable/index.tsx 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3307   +/-   ##
=======================================
  Coverage   74.62%   74.62%           
=======================================
  Files         279      279           
  Lines       10698    10699    +1     
  Branches     1289     1289           
=======================================
+ Hits         7983     7984    +1     
- Misses       2352     2353    +1     
+ Partials      363      362    -1     
Flag Coverage Δ
backend 83.89% <ø> (+0.02%) ⬆️
frontend 66.50% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review August 15, 2024 15:27
@imnasnainaec imnasnainaec changed the title Add isNew to WordAccess [DataEntryTable] Distinguish between new and updated words Aug 20, 2024
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 21, 2024 16:30
@imnasnainaec imnasnainaec merged commit 097f4af into master Aug 21, 2024
18 of 19 checks passed
@imnasnainaec imnasnainaec deleted the data-entry-recent-is-new branch August 21, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataEntry] Imported entry w/o domain can be deleted
2 participants