Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dockerfiles architecture neutral #3310

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Make Dockerfiles architecture neutral #3310

merged 4 commits into from
Aug 15, 2024

Conversation

jmgrady
Copy link
Collaborator

@jmgrady jmgrady commented Aug 15, 2024

This PRs included the following changes:

  • Remove the -amd64 specification from the images used in the backend;
  • Add a comment to the beginning of ./Dockerfile, ./Backend/Dockerfile, ./database/Dockerfile, and ./maintenance/Dockerfile to remind developers to not add architecture specific code to the Dockerfile; and
  • Add a comment to the beginning of ./deploy/Dockerfile stating that it is only supported on Intel/AMD platforms.

This change is Reviewable

@jmgrady jmgrady added the docker label Aug 15, 2024
@jmgrady jmgrady self-assigned this Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (87e875b) to head (0526e22).
Report is 27 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3310   +/-   ##
=======================================
  Coverage   74.62%   74.62%           
=======================================
  Files         279      279           
  Lines       10697    10697           
  Branches     1289     1289           
=======================================
  Hits         7983     7983           
  Misses       2351     2351           
  Partials      363      363           
Flag Coverage Δ
backend 83.87% <ø> (ø)
frontend 66.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@jmgrady jmgrady enabled auto-merge (squash) August 15, 2024 15:47
@jmgrady jmgrady merged commit ac10ab1 into master Aug 15, 2024
19 checks passed
@jmgrady jmgrady deleted the arch-neutral branch August 15, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants