Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnnouncementBanner tests; Fix defaultState location #3311

Merged
merged 13 commits into from
Aug 22, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 16, 2024

Completes the reorg of #3054
A small piece of #3180


This change is Reviewable

@imnasnainaec imnasnainaec added frontend test maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Aug 16, 2024
@imnasnainaec imnasnainaec self-assigned this Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.76%. Comparing base (f90b698) to head (060dd24).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3311      +/-   ##
==========================================
+ Coverage   74.58%   74.76%   +0.17%     
==========================================
  Files         279      278       -1     
  Lines       10710    10710              
  Branches     1291     1291              
==========================================
+ Hits         7988     8007      +19     
+ Misses       2358     2339      -19     
  Partials      364      364              
Flag Coverage Δ
backend 83.89% <ø> (+0.08%) ⬆️
frontend 66.77% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasonleenaylor
Copy link
Contributor

src/components/AnnouncementBanner/tests/index.test.tsx line 39 at r2 (raw file):

    await renderAnnouncementBanner();
    expect(
      screen.queryByLabelText(AnnouncementBannerTextId.ButtonClose)

Add a comment about why we are using the ButtonClose

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 20 of 25 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 21, 2024 18:28
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 0812f13 into master Aug 22, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the testing-library branch August 22, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants