Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataEntry] Let arrows to move out of vern/gloss suggestions #3321

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 23, 2024

Fixes #3320


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.81%. Comparing base (0812f13) to head (ddf011c).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
...Table/EntryCellComponents/GlossWithSuggestions.tsx 0.00% 2 Missing ⚠️
...yTable/EntryCellComponents/VernWithSuggestions.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3321      +/-   ##
==========================================
- Coverage   74.83%   74.81%   -0.02%     
==========================================
  Files         278      278              
  Lines       10710    10710              
  Branches     1291     1291              
==========================================
- Hits         8015     8013       -2     
- Misses       2333     2335       +2     
  Partials      362      362              
Flag Coverage Δ
backend 84.01% <ø> (-0.05%) ⬇️
frontend 66.77% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 7ef8502 into master Aug 23, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the isOptionEqualToValue branch August 23, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataEntry] After arrowing into vern/gloss suggestions, cannot arrow out
2 participants