-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataEntryTable] Remove "en" assumption #615
Conversation
…n' senses to show up in the dialogs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 9 files at r1.
Reviewable status: 8 of 9 files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/goals/ReviewEntries/ReviewEntriesComponent/ReviewEntriesTypes.ts, line 64 at r1 (raw file):
nalysisLang === undefined || gloss.language === analysisLang
So this has what I'd refer to as a code smell. I think that we should not allow analysisLang to be undefined to prevent future bugs from creeping up on us. Instead we should modify components which call this method to have access to the analysisLang.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might be at least one test warranted here. Something to prove we use the first analysis language if there are two?
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this time, projects are only allowed one analysis language.
Reviewed 7 of 10 files at r2, 5 of 5 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
Priority: Without this change, senses without "en" never show up in the NewEntry dialogs.
This change is