[ProjectSettings] Make project languages editable #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging a974ca7 into 1d1c357 - view on LGTM.com new alerts:
|
|
I was thinking the languages should be changeable in case a user (accidentally) selects an analysis language that doesn't match the lift import, in which case the senses wouldn't be visible in DataEntry > ExistingDataTable nor in ReviewEntries. However, it may be better to just allow adding more Analysis languages and switching which one is first in the list (i.e., active). |
|
We don't wan't to edit the languages. We only want: #712 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component in place, but update project errors, possibly a race condition:
This change is