[UserMenu] Unit tests: SiteSettings only visible to admins

[imnasnainaec]

Resolves #454

---

This change is 

[jasonleenaylor]

Reviewed 2 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

[jasonleenaylor]

---

src/components/AppBar/UserMenu.tsx, line 40 at r1 (raw file):

React.useEffect(() => {
    getIsAdmin();
  }, []);

enlighten me. What exactly did this try to do before?

[jasonleenaylor]

Reviewed 1 of 2 files at r2.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @imnasnainaec and @jasonleenaylor)

---

src/components/AppBar/tests/UserMenu.test.tsx, line 43 at r2 (raw file):

  });

  it("should only show site settings to general users", async () => {

maybe something here or in a comment below should mention what the extra admin menu item is. :)

[jasonleenaylor]

Reviewed 1 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

[imnasnainaec]

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @jasonleenaylor)

---

src/components/AppBar/UserMenu.tsx, line 40 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

React.useEffect(() => {
    getIsAdmin();
  }, []);

enlighten me. What exactly did this try to do before?

I think useEffect is triggered on render, and that was unnecessary in this context.

---

src/components/AppBar/tests/UserMenu.test.tsx, line 43 at r2 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

maybe something here or in a comment below should mention what the extra admin menu item is. :)

Ah, my description was backwards. Better?

[jasonleenaylor]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved