Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ProjectScreen] Fix property assignment in analysis language picker #644

Merged
merged 2 commits into from
Aug 25, 2020
Merged

[ProjectScreen] Fix property assignment in analysis language picker #644

merged 2 commits into from
Aug 25, 2020

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 25, 2020 •
edited by jasonleenaylor
Loading

The bpc47 code had mistakenly been given to LanguagePicker for name and font properties. See "en" showing up twice below:
image

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Aug 25, 2020
@imnasnainaec
Copy link
Collaborator Author

Fixed:
image

jasonleenaylor
jasonleenaylor approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 0f81946 into master Aug 25, 2020
@imnasnainaec imnasnainaec deleted the language-picker-display-error branch August 25, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonleenaylor jasonleenaylor jasonleenaylor approved these changes

Assignees

@imnasnainaec imnasnainaec

Labels
font/language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imnasnainaec @jasonleenaylor