Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync up @types/recordrtc package-lock.json with npm install #661

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Sync up @types/recordrtc package-lock.json with npm install #661

merged 1 commit into from
Aug 28, 2020

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Aug 28, 2020 •
edited by jasonleenaylor
Loading

I believe this update was accidentally missed in #649

This change is Reviewable

@johnthagen johnthagen added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Aug 28, 2020
@johnthagen johnthagen self-assigned this Aug 28, 2020
@johnthagen
Copy link
Collaborator Author

@imnasnainaec Could you double check this is intended? I think there was just a missing npm install run before you pushed up your final commits in #649, but want to confirm with you.

@johnthagen johnthagen changed the title Sync up @types/recordrtc dev flag with npm install Sync up @types/recordrtc package-lock.json with npm install Aug 28, 2020
@johnthagen johnthagen mentioned this pull request Aug 28, 2020
Merged
imnasnainaec
imnasnainaec approved these changes Aug 28, 2020
View reviewed changes
Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@imnasnainaec imnasnainaec merged commit 3fdfc20 into master Aug 28, 2020
@imnasnainaec imnasnainaec deleted the fix-package-lock branch August 28, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imnasnainaec imnasnainaec imnasnainaec approved these changes

Assignees

@johnthagen johnthagen

Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnthagen @imnasnainaec