Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LGTM badges to README #686

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Add LGTM badges to README #686

merged 2 commits into from
Sep 4, 2020

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Sep 4, 2020

Add LGTM badges to README to encourage high code quality


This change is Reviewable

@johnthagen johnthagen added the documentation Improvements or additions to documentation label Sep 4, 2020
@johnthagen johnthagen self-assigned this Sep 4, 2020
@imnasnainaec
Copy link
Collaborator

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @johnthagen)

a discussion (no related file):
What about c#?


@johnthagen
Copy link
Collaborator Author

a discussion (no related file):

Previously, imnasnainaec (D. Ror.) wrote…

What about c#?

LGTM doesn't support code "scores" for C# yet: https://lgtm.com/projects/g/sillsdev/TheCombine/ci/


Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johnthagen johnthagen merged commit bd5a2f4 into master Sep 4, 2020
@johnthagen johnthagen deleted the lgtm-badges branch September 4, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants