-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase max request body size to allow clients to import large projects #690
Conversation
Should be able to test once #693 is merged. |
I was able to successfully import a 60MB project and review the entries using this fix. Tested using production Docker build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
Without this fix, NGINX will block large POSTs from clients when they try to import large projects or upload audio clips longer than ~5 seconds:
Without this fix, Kestrel will also throw an error:
This sets the limit to 250MB. This can be tested using the project Docker build/launch instructions.
Relates to trying to reproduce #688
To test, try to import a project export >1MB (such as 60MB).
This change is