[AudioPlayer] Implement play-or-delete menu for touchscreen/tablet use #710
Conversation
|
Testing on an Acer laptop with a touchscreen and in Chromium with a User-Agent switcher. |
|
Running into two issues with long-press:
|
imnasnainaec
changed the title
|
Tried installing https://www.npmjs.com/package/react-native-device-info, but then TheCombine couldn't even compile. |
There was a problem hiding this comment.
Reviewed 3 of 5 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
src/components/Pronunciations/AudioPlayer.tsx, line 43 at r2 (raw file):
deletePlay
Not a big fan of this function name. What about deleteAudio?
There was a problem hiding this comment.
Reviewable status: 2 of 6 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @jasonleenaylor)
src/components/Pronunciations/AudioPlayer.tsx, line 43 at r2 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
deletePlayNot a big fan of this function name. What about deleteAudio?
Done
There was a problem hiding this comment.
Reviewable status: 2 of 6 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @jasonleenaylor)
src/components/Buttons/ButtonConfirmation.tsx, line 23 at r3 (raw file):
utton for archiving/restoring project (changing isActive)
Outdated comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 2 of 5 files at r2, 3 of 4 files at r3, 1 of 1 files at r4.
Reviewable status:
Resolves #681
The interface trigger should be (at least) one of:
This change is