Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tsc from package.json #727

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Sep 21, 2020

The tsc in package.json (introduced in #724) causes a failure for me (Ubuntu 18.04) when running npm start:

> thecombine@0.2.0-alpha.1 predatabase /home/dror/sil/TheCombine
> tsc setupMongo.ts && node setupMongo.js

setupMongo.ts(5,37): error TS1005: ';' expected.
setupMongo.ts(6,9): error TS1005: ';' expected.
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! thecombine@0.2.0-alpha.1 predatabase: `tsc setupMongo.ts && node setupMongo.js`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the thecombine@0.2.0-alpha.1 predatabase script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

This change is Reviewable

@imnasnainaec imnasnainaec added the bug Something isn't working label Sep 21, 2020
@imnasnainaec imnasnainaec self-assigned this Sep 21, 2020
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @imnasnainaec)


package.json, line 102 at r1 (raw file):

"typescript": "^3.9.7"

I assume the ability to actually call 'tsc' comes from here right?

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @imnasnainaec)


package.json, line 102 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…
"typescript": "^3.9.7"

I assume the ability to actually call 'tsc' comes from here right?

Yes, I believe so.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on Ubuntu 18.04 and Windows 10.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@imnasnainaec imnasnainaec merged commit ccb76e1 into master Sep 23, 2020
@imnasnainaec imnasnainaec deleted the remove-tsc-from-package-json branch September 23, 2020 17:55
@johnthagen
Copy link
Collaborator

Sorry, I had noticed this had been added to my PR, but thought it was needed by the reviewer. I will follow up on changes like this next time before PR is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants