Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to get lgtm to stop complaining about sensitive info in localStorage #730

Merged
merged 2 commits into from
Sep 25, 2020

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Sep 25, 2020

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Sep 25, 2020
@lgtm-com
Copy link

lgtm-com bot commented Sep 25, 2020

This pull request fixes 1 alert when merging dac473e into 344d7a4 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

@johnthagen
Copy link
Collaborator


src/goals/DefaultGoal/BaseGoalScreen/tests/BaseGoalScreen.test.tsx, line 41 at r2 (raw file):

  const div = document.createElement("div");
  let user: User = new User("TestUser", "TestUsername", "password");

Was LGTM flagging this because we used the name "password"?

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @johnthagen)


src/goals/DefaultGoal/BaseGoalScreen/tests/BaseGoalScreen.test.tsx, line 41 at r2 (raw file):

Previously, johnthagen wrote…

Was LGTM flagging this because we used the name "password"?

That's my understanding.

Copy link
Collaborator

@johnthagen johnthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@johnthagen johnthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johnthagen
Copy link
Collaborator

Nice clean up included in this PR too. ✔️

@lgtm-com
Copy link

lgtm-com bot commented Sep 25, 2020

This pull request fixes 1 alert when merging 89c0b5a into 344d7a4 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

@imnasnainaec imnasnainaec merged commit eeb8019 into master Sep 25, 2020
@imnasnainaec imnasnainaec deleted the passwords-in-jest branch September 25, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants