-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to get lgtm to stop complaining about sensitive info in localStorage #730
Conversation
This pull request fixes 1 alert when merging dac473e into 344d7a4 - view on LGTM.com fixed alerts:
|
src/goals/DefaultGoal/BaseGoalScreen/tests/BaseGoalScreen.test.tsx, line 41 at r2 (raw file):
Was LGTM flagging this because we used the name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @johnthagen)
src/goals/DefaultGoal/BaseGoalScreen/tests/BaseGoalScreen.test.tsx, line 41 at r2 (raw file):
Previously, johnthagen wrote…
Was LGTM flagging this because we used the name
"password"
?
That's my understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
Nice clean up included in this PR too. ✔️ |
This pull request fixes 1 alert when merging 89c0b5a into 344d7a4 - view on LGTM.com fixed alerts:
|
This change is