-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused variable in test #747
Conversation
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
==========================================
+ Coverage 50.31% 50.33% +0.01%
==========================================
Files 235 235
Lines 6169 6169
Branches 398 398
==========================================
+ Hits 3104 3105 +1
Misses 2772 2772
+ Partials 293 292 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @imnasnainaec)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/components/PasswordReset/tests/ResetPage.test.tsx, line 19 at r2 (raw file):
<PasswordReset resetState={0} passwordReset={jest.fn()} />
PasswordReset
still gives a Typescript warning because it is missing the properties of RouteComponentProps
I tried to resolve that using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
=======================================
Coverage 49.95% 49.95%
=======================================
Files 235 235
Lines 6158 6158
Branches 398 398
=======================================
Hits 3076 3076
Misses 2788 2788
Partials 294 294
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Fixes GitHub Actions warning: https://github.com/sillsdev/TheCombine/actions/runs/285286292
This change is