Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable in test #747

Merged
merged 4 commits into from
Oct 7, 2020
Merged

Remove unused variable in test #747

merged 4 commits into from
Oct 7, 2020

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Oct 4, 2020

Fixes GitHub Actions warning: https://github.com/sillsdev/TheCombine/actions/runs/285286292


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2020

Codecov Report

Merging #747 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
+ Coverage   50.31%   50.33%   +0.01%     
==========================================
  Files         235      235              
  Lines        6169     6169              
  Branches      398      398              
==========================================
+ Hits         3104     3105       +1     
  Misses       2772     2772              
+ Partials      293      292       -1     
Flag Coverage Δ
#backend 53.06% <ø> (ø)
#frontend 47.82% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../MergeDupGoal/MergeDupStep/MergeDupStepReducer.tsx 54.05% <0.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3caada5...f4f5f3d. Read the comment docs.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/components/PasswordReset/tests/ResetPage.test.tsx, line 19 at r2 (raw file):

        <PasswordReset resetState={0} passwordReset={jest.fn()} />

PasswordReset still gives a Typescript warning because it is missing the properties of RouteComponentProps

@imnasnainaec
Copy link
Collaborator

imnasnainaec commented Oct 6, 2020

<PasswordReset resetState={0} passwordReset={jest.fn()} />

PasswordReset still gives a Typescript warning because it is missing the properties of RouteComponentProps

I tried to resolve that using withRouter in a number of ways, but kept hitting dead ends, so I'm content to leave it for now.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #747 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #747   +/-   ##
=======================================
  Coverage   49.95%   49.95%           
=======================================
  Files         235      235           
  Lines        6158     6158           
  Branches      398      398           
=======================================
  Hits         3076     3076           
  Misses       2788     2788           
  Partials      294      294           
Flag Coverage Δ
#backend 53.06% <ø> (ø)
#frontend 47.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/components/PasswordReset/ResetPage/component.tsx 42.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1186cfe...bb8d16f. Read the comment docs.

@imnasnainaec imnasnainaec merged commit 3293987 into master Oct 7, 2020
@imnasnainaec imnasnainaec deleted the fix-unused-variable branch October 7, 2020 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants