[ProjectLanguages] Add new analysis language or select new default

[imnasnainaec]

Resolves #712 (or at least the first two items).

Projects have 1 analysis language on creation. In project setting, this pr adds a + button to reveal the language picker and add a secondary analysis language.

The top language in the list is the primary/default associated with new entries, so this pr also adds a ↑ button by all secondary analysis languages allow it to be selected as the new default.

---

This change is 

[codecov-io]

Codecov Report

Merging #751 (07b8265) into master (9bcf24c) will increase coverage by 0.05%.
The diff coverage is 64.00%.

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
+ Coverage   51.64%   51.69%   +0.05%     
==========================================
  Files         242      242              
  Lines        6628     6652      +24     
  Branches      422      422              
==========================================
+ Hits         3423     3439      +16     
- Misses       2894     2903       +9     
+ Partials      311      310       -1     

Flag	Coverage Δ
backend	56.41% <ø> (ø)
frontend	47.10% <64.00%> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...jectSettings/ProjectLanguages/ProjectLanguages.tsx	66.66% <64.00%> (-33.34%)	⬇️
.../MergeDupGoal/MergeDupStep/MergeDupStepReducer.tsx	51.94% <0.00%> (+1.29%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bcf24c...07b8265. Read the comment docs.

[jasonleenaylor]

---

src/components/ProjectSettings/ProjectLanguages/ProjectLanguages.tsx, line 55 at r5 (raw file):

      font: this.state.font,
    };
    this.props.project.analysisWritingSystems.push(ws);

I think we need to handle the case where a user accidentally adds a language they already have.

[imnasnainaec]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor)

---

src/components/ProjectSettings/ProjectLanguages/ProjectLanguages.tsx, line 55 at r5 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

I think we need to handle the case where a user accidentally adds a language they already have.

The submit button is disabled if isNewWritingSystem (below) returns false. Let me know if you want redundant safe-guards, in this function or via a comment somewhere.

[jasonleenaylor]

---

src/components/ProjectSettings/ProjectLanguages/ProjectLanguages.tsx, line 55 at r5 (raw file):

Previously, imnasnainaec (D. Ror.) wrote…

The submit button is disabled if isNewWritingSystem (below) returns false. Let me know if you want redundant safe-guards, in this function or via a comment somewhere.

Sorry that I didn't see that. We don't need the redundant safeguard, but we should have a unit test for it.

[imnasnainaec]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor)

---

src/components/ProjectSettings/ProjectLanguages/ProjectLanguages.tsx, line 55 at r5 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Sorry that I didn't see that. We don't need the redundant safeguard, but we should have a unit test for it.

Added.

[jasonleenaylor]

Reviewed 2 of 3 files at r5, 1 of 1 files at r6.
Reviewable status: complete! all files reviewed, all discussions resolved