Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize backend and frontend format script names #757

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Oct 9, 2020

In a similar vein of our test-frontend and test-backend script names, normalize the fmt scripts that automatically format code.

These also more closely align to the Python tox -e fmt command to format the Python code.


This change is Reviewable

@johnthagen johnthagen self-assigned this Oct 9, 2020
@codecov-io
Copy link

codecov-io commented Oct 9, 2020

Codecov Report

Merging #757 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   50.24%   50.24%           
=======================================
  Files         235      235           
  Lines        6158     6158           
  Branches      398      398           
=======================================
  Hits         3094     3094           
  Misses       2770     2770           
  Partials      294      294           
Flag Coverage Δ
#backend 53.67% <ø> (ø)
#frontend 47.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8096f...32392ef. Read the comment docs.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)

@johnthagen johnthagen merged commit 12824c5 into master Oct 9, 2020
@johnthagen johnthagen deleted the fmt-scripts branch October 9, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants