Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On lift import, preserve entry guids #761

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 12, 2020

This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working import/export labels Oct 12, 2020
@imnasnainaec imnasnainaec self-assigned this Oct 12, 2020
@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #761 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #761      +/-   ##
==========================================
- Coverage   50.24%   50.23%   -0.01%     
==========================================
  Files         235      235              
  Lines        6158     6159       +1     
  Branches      398      398              
==========================================
  Hits         3094     3094              
  Misses       2770     2770              
- Partials      294      295       +1     
Flag Coverage Δ
#backend 53.68% <100.00%> (+0.01%) ⬆️
#frontend 47.05% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Backend/Services/LiftApiServices.cs 94.61% <100.00%> (+0.01%) ⬆️
.../MergeDupGoal/MergeDupStep/MergeDupStepReducer.tsx 52.70% <0.00%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8bd59...4975625. Read the comment docs.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@jasonleenaylor jasonleenaylor merged commit 843cb4c into master Oct 12, 2020
@jasonleenaylor jasonleenaylor deleted the lift-import-word-guid branch October 12, 2020 21:23
This was referenced Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working import/export
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants