Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation cleanup before crowdin sync #770

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 16, 2020

Since The Combine is out of sync with crowdin, some translations needed to be manual transferred before re-syncing.
In this pr:

  • Removed unnecessary phrases;
  • Cleanup capitalization/punctuation/spacing;
  • Add crowdin translations not previously transferred (but probably missed a few);
  • Repeat English phrase where translation is missing.

Once in crowdin, all existing translations can be reviewed and (re)approved, and missing translations added.


This change is Reviewable

… Add crowdin translations (or English where translation is missing)
Copy link
Collaborator

@johnthagen johnthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #770 into master will decrease coverage by 3.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
- Coverage   51.16%   47.32%   -3.85%     
==========================================
  Files         235      198      -37     
  Lines        6240     3235    -3005     
  Branches      404      404              
==========================================
- Hits         3193     1531    -1662     
+ Misses       2749     1406    -1343     
  Partials      298      298              
Flag Coverage Δ
#backend ?
#frontend 47.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ectScreen/CreateProject/CreateProjectComponent.tsx 26.47% <ø> (ø)
Backend/Contexts/UserContext.cs
Backend/Controllers/ProjectController.cs
Backend/Program.cs
Backend/Contexts/UserEditContext.cs
Backend/Controllers/FrontierController.cs
Backend/Services/WordApiServices.cs
Backend/Services/UserRoleApiServices.cs
Backend/Helper/FileUtilities.cs
Backend/Models/User.cs
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23687a...6715e78. Read the comment docs.

@imnasnainaec imnasnainaec merged commit 5a6a453 into master Oct 16, 2020
@imnasnainaec imnasnainaec deleted the manual-translation-update-from-crowdin branch October 16, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants