Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read audio files & avatars asynchronously #785

Merged
merged 4 commits into from
Oct 30, 2020
Merged

Read audio files & avatars asynchronously #785

merged 4 commits into from
Oct 30, 2020

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Oct 30, 2020 •
edited
Loading

This should improve performance by using async appropriately on:

  • Audio Files
  • Avatars

This change is Reviewable

@johnthagen johnthagen self-assigned this Oct 30, 2020
@johnthagen johnthagen changed the title Read audio files asynchronously to improve performance Read audio files & avatars asynchronously Oct 30, 2020
imnasnainaec
imnasnainaec approved these changes Oct 30, 2020
View reviewed changes
Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johnthagen johnthagen removed the docker label Oct 30, 2020
@johnthagen
Copy link
Collaborator Author

The Docker change was an accidental check-in. It has been reverted.

@codecov-io

This comment has been minimized.

Sign in to view
@johnthagen johnthagen merged commit 918c72d into master Oct 30, 2020
@johnthagen johnthagen deleted the async-audio-download branch October 30, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imnasnainaec imnasnainaec imnasnainaec approved these changes

Assignees

@johnthagen johnthagen

Labels
audio backend performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnthagen @codecov-io @imnasnainaec