Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewEntry] Allow submission with no gloss #796

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Nov 3, 2020

Resolves #607


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Nov 3, 2020
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/components/DataEntry/DataEntryTable/NewEntry/NewEntry.tsx, line 363 at r1 (raw file):

this.handleEnter(e, false)

Add comment to explain the false and why we want to allow it

@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #796 into master will decrease coverage by 0.02%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
- Coverage   51.24%   51.22%   -0.03%     
==========================================
  Files         237      237              
  Lines        6430     6433       +3     
  Branches      410      412       +2     
==========================================
  Hits         3295     3295              
- Misses       2832     2833       +1     
- Partials      303      305       +2     
Flag Coverage Δ
backend 55.22% <ø> (ø)
frontend 47.35% <12.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/DataEntry/DataEntryTable/NewEntry/NewEntry.tsx 17.00% <0.00%> (-0.18%) ⬇️
src/types/word.tsx 87.50% <33.33%> (-7.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a436818...f6e9215. Read the comment docs.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit b3b87b1 into master Nov 4, 2020
@imnasnainaec imnasnainaec deleted the allow-empty-gloss-on-new-entry branch November 4, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataEntryTable] Allow submission of new entries with empty gloss
3 participants