Consolidate navigation paths; Cleanup GoalTimeline folder structure #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnasnainaec
added
frontend
maintenance
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
+ Coverage 51.24% 55.23% +3.99%
==========================================
Files 237 37 -200
Lines 6442 3159 -3283
Branches 415 0 -415
==========================================
- Hits 3301 1745 -1556
+ Misses 2834 1414 -1420
+ Partials 307 0 -307
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
jmgrady
approved these changes
Nov 11, 2020
There was a problem hiding this comment.
Reviewed 24 of 29 files at r1, 5 of 5 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The url paths used for navigation are strings specified in every instance where they're needed. This pr defines those path strings all in one place (
/src/history.ts) so they can be used and edited more easily.The name GoalTimelineVertical is both unnecessarily long (since there is no GoalTimelineHorizontal to be distinguished from) and misleading (since it is only vertical for some window sizes). The naming and surrounding file structure are simplified in this pr.
This change is