Centralize the AppBar; Remove extraneous component wrappers

[imnasnainaec]

In the routing of src/App/component.tsx, separate out all pages that can only be accessed after login under a new AppLoggedIn.tsx, and place a single global AppBar within this new component, so we don't have to maintain a new instance within every page within the app.

---

This change is 

[codecov-io]

Codecov Report

Merging #807 (993aa0a) into master (5c1a0f2) will decrease coverage by 0.03%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
- Coverage   51.18%   51.15%   -0.04%     
==========================================
  Files         237      237              
  Lines        6449     6459      +10     
  Branches      416      418       +2     
==========================================
+ Hits         3301     3304       +3     
- Misses       2841     2846       +5     
- Partials      307      309       +2     

Flag	Coverage Δ
backend	55.23% <ø> (ø)
frontend	47.24% <53.84%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/components/App/AppLoggedIn.tsx	0.00% <0.00%> (ø)
src/components/App/component.tsx	100.00% <ø> (ø)
src/components/AppBar/NavigationButtons.tsx	33.33% <ø> (ø)
src/components/AppBar/ProjectNameButton.tsx	66.66% <ø> (ø)
.../components/GoalTimeline/GoalTimelineComponent.tsx	68.75% <ø> (ø)
src/components/PageNotFound/component.tsx	50.00% <ø> (ø)
...nents/ProjectSettings/ProjectSettingsComponent.tsx	0.00% <ø> (ø)
.../components/SiteSettings/SiteSettingsComponent.tsx	0.00% <0.00%> (ø)
src/components/UserSettings/UserSettings.tsx	0.00% <ø> (ø)
...oals/DefaultGoal/BaseGoalScreen/BaseGoalScreen.tsx	71.42% <0.00%> (-14.29%)	⬇️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c1a0f2...993aa0a. Read the comment docs.

[johnthagen]

---

src/history.ts, line 13 at r2 (raw file):

export default history;

export enum path {

I'm not sure this needs to change, but when I first say a lowercased item like this, I think it was a built in (like string, etc).

Could this be renamed to Path so it's a little more obvious this is a custom type?

Also, I think canonically, on the web these things are called "routes" rather than "paths".

So maybe: Route or AppRoute to make it really clear?

[johnthagen]

---

src/components/AppBar/AppBarComponent.tsx, line 16 at r2 (raw file):

}

/** An app bar shown at the top of almost every page of The Combine */

Could rephrase to say: "Shown on all logged in pages" or equivalent.

[johnthagen]

---

src/history.ts, line 14 at r2 (raw file):

export enum path {
  dataEntry = "/app/data-entry",

It also looks like TypeScript prefers UpperCamelCase for enum members: https://www.typescriptlang.org/docs/handbook/enums.html

[johnthagen]

---

src/history.ts, line 13 at r2 (raw file):

Previously, johnthagen wrote…

I'm not sure this needs to change, but when I first say a lowercased item like this, I think it was a built in (like string, etc).

Could this be renamed to Path so it's a little more obvious this is a custom type?

Also, I think canonically, on the web these things are called "routes" rather than "paths".

So maybe: Route or AppRoute to make it really clear?

I see that other parts of React already have Route, so maybe something like AppRoute would be the best here.

[johnthagen]

---

src/goals/DefaultGoal/BaseGoalScreen/BaseGoalScreen.tsx, line 55 at r2 (raw file):

 * based on the current step in the goal
 */
export default class BaseGoalScreen extends React.Component<GoalProps> {

Could this become a functional component while we are here?

[johnthagen]

Reviewed 17 of 19 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @imnasnainaec)

[imnasnainaec]

Reviewable status: 8 of 37 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @johnthagen)

---

src/history.ts, line 13 at r2 (raw file):

Previously, johnthagen wrote…

I see that other parts of React already have Route, so maybe something like AppRoute would be the best here.

Path implemented

---

src/components/AppBar/AppBarComponent.tsx, line 16 at r2 (raw file):

Previously, johnthagen wrote…

Could rephrase to say: "Shown on all logged in pages" or equivalent.

Done

---

src/goals/DefaultGoal/BaseGoalScreen/BaseGoalScreen.tsx, line 55 at r2 (raw file):

Previously, johnthagen wrote…

Could this become a functional component while we are here?

I had tried that, but it doesn't play well with BaseGoalScreen/index.tsx

[johnthagen]

---

src/history.ts, line 14 at r3 (raw file):

export enum Path {
  dataEntry = "/app/data-entry",

enum members should start with a capital letter: https://www.typescriptlang.org/docs/handbook/enums.html

DataEntry = ...

[johnthagen]

Reviewed 29 of 29 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)

[imnasnainaec]

Reviewable status: 10 of 42 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @johnthagen)

---

src/history.ts, line 14 at r3 (raw file):

Previously, johnthagen wrote…

enum members should start with a capital letter: https://www.typescriptlang.org/docs/handbook/enums.html

DataEntry = ...

Done.

[johnthagen]

Reviewed 1 of 32 files at r4.
Reviewable status: 11 of 42 files reviewed, all discussions resolved (waiting on @johnthagen)

[johnthagen]

Reviewed 31 of 32 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved