Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set AWS profile for ECR to ecr_read_only #831

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Conversation

jmgrady
Copy link
Collaborator

@jmgrady jmgrady commented Nov 30, 2020

Set the profile used to access the AWS Elastic Container Registry to ecr_read_only for QA servers. Servers (QA & Live server) only need to download docker images; they do not create images to upload to the registry.


This change is Reviewable

@jmgrady jmgrady added bug Something isn't working deployment docker labels Nov 30, 2020
@jmgrady jmgrady self-assigned this Nov 30, 2020
Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@jmgrady jmgrady merged commit a5eb106 into master Nov 30, 2020
@jmgrady jmgrady deleted the set_ecr_profile_read_only branch November 30, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployment docker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants