Move Tooltip inside RecorderIcon. #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnasnainaec
added
refactor
maintenance
jasonleenaylor
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #838.
The
refproperty is not implicit with a functional component as it is for a traditional component.Thus,
Tooltipcannot be used around a functional component, because it tries to pass itsrefto its children.Previously in
AudioRecorder, we hadTooltipwrapped around the functional componentRecorderIcon.To fix the associated warnings, this pr moves
Tooltipto withinRecorderIcon.Should we ever need tooltip around a functional component: https://material-ui.com/guides/composition/#caveat-with-refs
This change is