Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert AvatarUpload testing from react-dom to react-test-renderer. #840

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 2, 2020

This resolves three warnings thrown by npm run test-frontend -- AvatarUpload.


This change is Reviewable

@codecov-io
Copy link

codecov-io commented Dec 2, 2020

Codecov Report

Merging #840 (2a2bb85) into master (41205b9) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
+ Coverage   51.26%   51.27%   +0.01%     
==========================================
  Files         238      238              
  Lines        6611     6611              
  Branches      421      421              
==========================================
+ Hits         3389     3390       +1     
  Misses       2909     2909              
+ Partials      313      312       -1     
Flag Coverage Δ
backend 55.84% <ø> (ø)
frontend 46.81% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../MergeDupGoal/MergeDupStep/MergeDupStepReducer.tsx 51.94% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41205b9...2a2bb85. Read the comment docs.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@imnasnainaec imnasnainaec merged commit 9fe6251 into master Dec 4, 2020
@imnasnainaec imnasnainaec deleted the avatar-upload-test branch December 4, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants