Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update App, GoalRoute testing #841

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Update App, GoalRoute testing #841

merged 3 commits into from
Dec 4, 2020

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 3, 2020

  • react-dom -> react-test-renderer
  • use jest-canvas-mock to solve warning

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Dec 3, 2020
@codecov-io
Copy link

codecov-io commented Dec 3, 2020

Codecov Report

Merging #841 (081913d) into master (9fe6251) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #841   +/-   ##
=======================================
  Coverage   51.27%   51.27%           
=======================================
  Files         238      238           
  Lines        6611     6611           
  Branches      421      421           
=======================================
  Hits         3390     3390           
  Misses       2909     2909           
  Partials      312      312           
Flag Coverage Δ
backend 55.84% <ø> (ø)
frontend 46.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe6251...081913d. Read the comment docs.

@imnasnainaec imnasnainaec changed the title Update App testing Update App, GoalRoute testing Dec 3, 2020
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 4b59d8a into master Dec 4, 2020
@imnasnainaec imnasnainaec deleted the app-testing branch December 4, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants