Add .github, docker_deploy folders and .yml files to fmt-frontend. #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnasnainaec
added
the
maintenance
jmgrady
requested changes
Dec 8, 2020
There was a problem hiding this comment.
Reviewed 13 of 13 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
docker_deploy/group_vars/server/main.yml, line 38 at r1 (raw file):
backup_hour: "3" backup_minute: "15" num_backups: "3"
I think that in this case, and others like it, the code is harder to read once prettier has reformatted it. Let's discuss.
|
This change is not helpful at this time. |
|
... but it's reasonable. |
jmgrady
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The meat of this pr is the change to
fmt-frontendandfmt-frontend-checkinpackage.jsonand the addition to.vscode/settings.json--the other files were modified as a consequence.This change is