Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vestigial Goal property Tool. #857

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 8, 2020

Was never implemented.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Dec 8, 2020
@imnasnainaec imnasnainaec added the maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. label Dec 8, 2020
@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

Merging #857 (b11250a) into master (f4af26f) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
- Coverage   51.68%   51.63%   -0.06%     
==========================================
  Files         242      242              
  Lines        6636     6627       -9     
  Branches      422      422              
==========================================
- Hits         3430     3422       -8     
+ Misses       2895     2894       -1     
  Partials      311      311              
Flag Coverage Δ
backend 56.41% <ø> (ø)
frontend 46.95% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/goals/CreateCharInv/CreateCharInv.tsx 100.00% <ø> (ø)
src/goals/CreateStrWordInv/CreateStrWordInv.tsx 100.00% <ø> (ø)
src/goals/HandleFlags/HandleFlags.tsx 100.00% <ø> (ø)
src/goals/MergeDupGoal/MergeDups.tsx 100.00% <ø> (ø)
src/goals/ReviewEntries/ReviewEntries.tsx 100.00% <ø> (ø)
src/goals/SpellCheckGloss/SpellCheckGloss.tsx 100.00% <ø> (ø)
src/goals/ValidateChars/ValidateChars.tsx 100.00% <ø> (ø)
src/goals/ValidateStrWords/ValidateStrWords.tsx 0.00% <ø> (ø)
src/types/baseGoal.tsx 100.00% <ø> (ø)
src/types/goals.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4af26f...b11250a. Read the comment docs.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 8e0027b into master Dec 8, 2020
@imnasnainaec imnasnainaec deleted the expunge-goal-tools branch December 8, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants