Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-button props from those passed to Button. #861

Merged
merged 6 commits into from
Dec 13, 2020

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 11, 2020

Resolves #662

This is sadly a case-by-case manual fix. I wanted to define a general-purpose function to remove from props anything in a specified interface, but https://stackoverflow.com/a/58280921


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Dec 11, 2020
@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

Merging #861 (72c92ef) into master (0a8593c) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #861   +/-   ##
=======================================
  Coverage   51.63%   51.63%           
=======================================
  Files         242      242           
  Lines        6627     6627           
  Branches      422      422           
=======================================
  Hits         3422     3422           
  Misses       2894     2894           
  Partials      311      311           
Flag Coverage Δ
backend 56.41% <ø> (ø)
frontend 46.95% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/Buttons/ButtonConfirmation.tsx 33.33% <ø> (ø)
src/components/Buttons/DeleteDialog.tsx 100.00% <ø> (ø)
src/components/Buttons/EditTextDialog.tsx 23.52% <ø> (ø)
src/components/Buttons/FileInputButton.tsx 20.00% <0.00%> (ø)
src/components/Buttons/LoadingButton.tsx 100.00% <ø> (ø)
src/components/Buttons/LoadingDoneButton.tsx 100.00% <ø> (ø)
...components/PasswordReset/RequestPage/component.tsx 0.00% <0.00%> (ø)
...c/components/ProjectExport/ExportProjectButton.tsx 75.00% <ø> (ø)
...ectScreen/CreateProject/CreateProjectComponent.tsx 26.47% <ø> (ø)
...ts/ProjectSettings/ProjectImport/ProjectImport.tsx 0.00% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8593c...72c92ef. Read the comment docs.

Copy link
Collaborator

@johnthagen johnthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 9 files at r1, 9 of 10 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johnthagen
Copy link
Collaborator

I think using composition in the way makes this code easier to understand. Great job.

@imnasnainaec imnasnainaec merged commit 326b3a8 into master Dec 13, 2020
@imnasnainaec imnasnainaec deleted the button-prop-spread branch December 13, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console warnings shown when logging into application
3 participants