-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-button props from those passed to Button. #861
Conversation
Codecov Report
@@ Coverage Diff @@
## master #861 +/- ##
=======================================
Coverage 51.63% 51.63%
=======================================
Files 242 242
Lines 6627 6627
Branches 422 422
=======================================
Hits 3422 3422
Misses 2894 2894
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 9 files at r1, 9 of 10 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
I think using composition in the way makes this code easier to understand. Great job. |
Resolves #662
This is sadly a case-by-case manual fix. I wanted to define a general-purpose function to remove from
props
anything in a specified interface, but https://stackoverflow.com/a/58280921This change is