Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bad justify prop. #869

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Remove bad justify prop. #869

merged 1 commit into from
Dec 16, 2020

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 16, 2020 •
edited
Loading

Incorrectly added in #862, triggers a Console warning on the Login Page.
Only works on <Grid container>; does nothing in <Grid item>.

This change is Reviewable

@imnasnainaec imnasnainaec added the maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. label Dec 16, 2020
@imnasnainaec imnasnainaec self-assigned this Dec 16, 2020
jmgrady
jmgrady approved these changes Dec 16, 2020
View reviewed changes
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@jmgrady jmgrady merged commit 3d2449b into master Dec 16, 2020
@jmgrady jmgrady deleted the console-warning-justify branch December 16, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmgrady jmgrady jmgrady approved these changes

Assignees

@imnasnainaec imnasnainaec

Labels
maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imnasnainaec @jmgrady