Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream all file downloads #878

Merged
merged 6 commits into from
Dec 22, 2020
Merged

Stream all file downloads #878

merged 6 commits into from
Dec 22, 2020

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Dec 18, 2020

  • This reduces peak/persistent memory usage of downloading a 116MB Lift export by ~116MB.

Closes #811


This change is Reviewable

@johnthagen

This comment has been minimized.

@johnthagen
Copy link
Collaborator Author

Avatar display issues are unrelated to this PR: #879

@codecov-io
Copy link

codecov-io commented Dec 18, 2020

Codecov Report

Merging #878 (e80d027) into master (28f2dfa) will not change coverage.
The diff coverage is 68.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #878   +/-   ##
=======================================
  Coverage   51.01%   51.01%           
=======================================
  Files         241      241           
  Lines        6590     6590           
  Branches      418      418           
=======================================
  Hits         3362     3362           
  Misses       2918     2918           
  Partials      310      310           
Flag Coverage Δ
backend 56.15% <68.00%> (ø)
frontend 45.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Backend/Controllers/AvatarController.cs 57.89% <0.00%> (ø)
Backend/Controllers/FrontierController.cs 0.00% <0.00%> (ø)
Backend/Services/EmailService.cs 0.00% <ø> (ø)
Backend/Services/PermissionService.cs 0.00% <0.00%> (ø)
Backend/Controllers/AudioController.cs 52.63% <40.00%> (ø)
Backend/Controllers/ProjectController.cs 31.36% <55.55%> (ø)
Backend/Controllers/WordController.cs 50.00% <71.42%> (ø)
Backend/Controllers/LiftController.cs 52.72% <85.71%> (ø)
Backend/Controllers/UserController.cs 46.21% <100.00%> (ø)
Backend/Controllers/UserEditController.cs 63.24% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f2dfa...e80d027. Read the comment docs.

@johnthagen

This comment has been minimized.

@johnthagen

This comment has been minimized.

@johnthagen
Copy link
Collaborator Author

LGTM build failures unrelated and tracked in #883

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 14 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 7 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)

@imnasnainaec imnasnainaec merged commit d269954 into master Dec 22, 2020
@imnasnainaec imnasnainaec deleted the stream-files branch December 22, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce peak memory usage during Lift Export
4 participants