Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DownloadButton] Simplify with switch statements. #886

Merged
merged 4 commits into from
Dec 22, 2020

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 21, 2020

This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. import/export labels Dec 21, 2020
@imnasnainaec imnasnainaec self-assigned this Dec 21, 2020
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #886 (b3f8626) into master (d269954) will decrease coverage by 0.10%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
- Coverage   51.01%   50.91%   -0.11%     
==========================================
  Files         241      241              
  Lines        6590     6601      +11     
  Branches      418      421       +3     
==========================================
- Hits         3362     3361       -1     
- Misses       2918     2926       +8     
- Partials      310      314       +4     
Flag Coverage Δ
backend 56.15% <ø> (ø)
frontend 45.65% <20.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/ProjectExport/DownloadButton.tsx 29.03% <20.00%> (-15.97%) ⬇️
.../MergeDupGoal/MergeDupStep/MergeDupStepReducer.tsx 50.64% <0.00%> (-1.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d269954...b3f8626. Read the comment docs.

@imnasnainaec imnasnainaec merged commit 3f14821 into master Dec 22, 2020
@imnasnainaec imnasnainaec deleted the downloading-status branch December 22, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend import/export maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants