Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly use async/await in all areas it can be used in backend #893

Merged
merged 2 commits into from
Dec 31, 2020

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Dec 31, 2020

Fixes part of #882.

Use async / await rather than .Result in all API methods to increase performance.


This change is Reviewable

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov-io
Copy link

codecov-io commented Dec 31, 2020

Codecov Report

Merging #893 (1d3836c) into master (6bc23e1) will not change coverage.
The diff coverage is 81.25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #893   +/-   ##
=======================================
  Coverage   50.93%   50.93%           
=======================================
  Files         241      241           
  Lines        6601     6601           
  Branches      421      421           
=======================================
  Hits         3362     3362           
  Misses       2926     2926           
  Partials      313      313           
Flag Coverage Δ
backend 56.15% <81.25%> (ø)
frontend 45.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Backend/Controllers/UserController.cs 46.21% <0.00%> (ø)
Backend/Services/PermissionService.cs 0.00% <0.00%> (ø)
Backend/Services/UserApiServices.cs 0.00% <0.00%> (ø)
Backend/Controllers/UserEditController.cs 63.24% <100.00%> (ø)
Backend/Services/LiftApiServices.cs 93.34% <100.00%> (ø)
Backend/Services/UserEditApiServices.cs 100.00% <100.00%> (ø)
Backend/Services/WordApiServices.cs 86.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc23e1...1d3836c. Read the comment docs.

@johnthagen johnthagen merged commit 5bd252d into master Dec 31, 2020
@johnthagen johnthagen deleted the await-refactor branch December 31, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants