-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend Refactor #895
Backend Refactor #895
Conversation
Codecov Report
@@ Coverage Diff @@
## master #895 +/- ##
==========================================
- Coverage 50.91% 50.76% -0.16%
==========================================
Files 241 241
Lines 6597 6631 +34
Branches 423 423
==========================================
+ Hits 3359 3366 +7
- Misses 2922 2949 +27
Partials 316 316
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Make all custom exceptions Serializable Turn Backend Test compile warnings into errors
…UserEditApiServices to properly handle missing IDs
…atement, it is a program error if this is not the case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, 36 of 36 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
Closes #882
Follow on to #892
Cleanup:
WordRepository.GetWord
andWordService.Delete
type signatures to properly returnnull
on failureUserEditRepository.GetUserEdit
&UserEditApiServices
to properly handle missing IDsUserController.Get
UserRoleApiServices.GetUserRole
to properly handle missing IDsUserApiServices.GetUserAvatar
to properly handle missing user IDsnull
checks proven by the compiler to not be possibleExceptions
Serializable
Assert.IsInstanceOf<>()
to simplify testsThis change is