-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MergeStack refactor #906
MergeStack refactor #906
Conversation
This comment has been minimized.
This comment has been minimized.
This pull request fixes 1 alert when merging d7b56ab into 8ba4266 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great other than the ignores for exhaustive-deps. I was running into that when working on the context changes and ended up adding a bunch of useCallback hooks. What are the consequences of ignoring here?
Reviewed 4 of 5 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## master #906 +/- ##
==========================================
- Coverage 50.45% 50.42% -0.04%
==========================================
Files 241 240 -1
Lines 6657 6659 +2
Branches 424 424
==========================================
- Hits 3359 3358 -1
- Misses 2980 2982 +2
- Partials 318 319 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This pull request fixes 1 alert when merging b612c6c into 8ba4266 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This pull request fixes 1 alert when merging 21c3357 into d0e95ea - view on LGTM.com fixed alerts:
|
Resolves last LGTM warning.
This change is