Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MergeStack refactor #906

Merged
merged 6 commits into from
Jan 12, 2021
Merged

MergeStack refactor #906

merged 6 commits into from
Jan 12, 2021

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 12, 2021

Resolves last LGTM warning.


This change is Reviewable

@lgtm-com

This comment has been minimized.

@lgtm-com
Copy link

lgtm-com bot commented Jan 12, 2021

This pull request fixes 1 alert when merging d7b56ab into 8ba4266 - view on LGTM.com

fixed alerts:

  • 1 for Unsupported state update in lifecycle method

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great other than the ignores for exhaustive-deps. I was running into that when working on the context changes and ended up adding a bunch of useCallback hooks. What are the consequences of ignoring here?

Reviewed 4 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #906 (b612c6c) into master (8ba4266) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
- Coverage   50.45%   50.42%   -0.04%     
==========================================
  Files         241      240       -1     
  Lines        6657     6659       +2     
  Branches      424      424              
==========================================
- Hits         3359     3358       -1     
- Misses       2980     2982       +2     
- Partials      318      319       +1     
Flag Coverage Δ
backend 55.47% <ø> (ø)
frontend 45.31% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...upGoal/MergeDupStep/MergeRow/MergeRowComponent.tsx 0.00% <ø> (ø)
.../MergeDupGoal/MergeDupStep/MergeRow/MergeStack.tsx 0.00% <0.00%> (ø)
.../MergeDupGoal/MergeDupStep/MergeDupStepReducer.tsx 50.64% <0.00%> (-1.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ba4266...b612c6c. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jan 12, 2021

This pull request fixes 1 alert when merging b612c6c into 8ba4266 - view on LGTM.com

fixed alerts:

  • 1 for Unsupported state update in lifecycle method

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@lgtm-com
Copy link

lgtm-com bot commented Jan 12, 2021

This pull request fixes 1 alert when merging 21c3357 into d0e95ea - view on LGTM.com

fixed alerts:

  • 1 for Unsupported state update in lifecycle method

@imnasnainaec imnasnainaec merged commit f2bf38a into master Jan 12, 2021
@imnasnainaec imnasnainaec deleted the merge-stack-refactor branch January 12, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants