Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement StoreStateDispatch type for all dispatches. #916

Merged
merged 9 commits into from
Jan 15, 2021

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 15, 2021

Follow up on #915


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jan 15, 2021
@codecov-io
Copy link

codecov-io commented Jan 15, 2021

Codecov Report

Merging #916 (e109a4e) into master (664cb0b) will not change coverage.
The diff coverage is 52.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #916   +/-   ##
=======================================
  Coverage   50.40%   50.40%           
=======================================
  Files         237      237           
  Lines        6656     6656           
  Branches      424      424           
=======================================
  Hits         3355     3355           
  Misses       2983     2983           
  Partials      318      318           
Flag Coverage Δ
backend 55.47% <ø> (ø)
frontend 45.26% <52.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/GoalTimeline/GoalSelectorScroll/index.tsx 100.00% <ø> (ø)
src/components/GoalTimeline/index.tsx 0.00% <ø> (ø)
src/components/Login/LoginPage/index.tsx 80.00% <ø> (ø)
src/components/Login/RegisterPage/index.tsx 0.00% <ø> (ø)
src/components/PasswordReset/RequestPage/index.tsx 0.00% <ø> (ø)
src/components/PasswordReset/ResetPage/index.tsx 0.00% <ø> (ø)
src/components/PasswordReset/actions.tsx 26.66% <0.00%> (ø)
.../components/ProjectExport/ExportProjectActions.tsx 0.00% <0.00%> (ø)
src/components/ProjectExport/index.tsx 66.66% <ø> (ø)
src/components/ProjectInvite/index.tsx 0.00% <ø> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 664cb0b...e109a4e. Read the comment docs.

@imnasnainaec imnasnainaec added the maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. label Jan 15, 2021
@jasonleenaylor
Copy link
Contributor


src/components/GoalTimeline/GoalsActions.tsx, line 57 at r1 (raw file):

Dispatch<GoalAction>

So, this wasn't a thunk dispatch before...

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 32 files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/components/GoalTimeline/GoalsActions.tsx, line 57 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…
Dispatch<GoalAction>

So, this wasn't a thunk dispatch before...

I'm under the impression that ThunkDispatch encompasses all our dispatches, but I welcome clarification.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 32 of 32 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


src/components/GoalTimeline/GoalsActions.tsx, line 57 at r1 (raw file):

Previously, imnasnainaec (D. Ror.) wrote…

I'm under the impression that ThunkDispatch encompasses all our dispatches, but I welcome clarification.

Yes, it should, as I thought further on this the real question is why wasn't it one before.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 34c488c into master Jan 15, 2021
@imnasnainaec imnasnainaec deleted the dispatch-update branch January 15, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants