-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement StoreStateDispatch type for all dispatches. #916
Conversation
Codecov Report
@@ Coverage Diff @@
## master #916 +/- ##
=======================================
Coverage 50.40% 50.40%
=======================================
Files 237 237
Lines 6656 6656
Branches 424 424
=======================================
Hits 3355 3355
Misses 2983 2983
Partials 318 318
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
src/components/GoalTimeline/GoalsActions.tsx, line 57 at r1 (raw file):
So, this wasn't a thunk dispatch before... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 32 files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/components/GoalTimeline/GoalsActions.tsx, line 57 at r1 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
Dispatch<GoalAction>
So, this wasn't a thunk dispatch before...
I'm under the impression that ThunkDispatch encompasses all our dispatches, but I welcome clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 32 of 32 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
src/components/GoalTimeline/GoalsActions.tsx, line 57 at r1 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
I'm under the impression that ThunkDispatch encompasses all our dispatches, but I welcome clarification.
Yes, it should, as I thought further on this the real question is why wasn't it one before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Follow up on #915
This change is