Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move goal-general function from CharacterInventory to GoalActions. #923

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 16, 2021

Twin pr to #922.

A follow-up pr is needed to work the bugs out of these goal-general functions and make sure they are generally useful.

This change is Reviewable

@imnasnainaec imnasnainaec added maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. goal labels Jan 16, 2021
@imnasnainaec imnasnainaec self-assigned this Jan 16, 2021
@codecov-io
Copy link

codecov-io commented Jan 16, 2021

Codecov Report

Merging #923 (e49dc46) into master (c4f43f8) will not change coverage.
The diff coverage is 68.18%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #923   +/-   ##
=======================================
  Coverage   50.40%   50.40%           
=======================================
  Files         238      238           
  Lines        6660     6660           
  Branches      425      425           
=======================================
  Hits         3357     3357           
  Misses       2985     2985           
  Partials      318      318           
Flag Coverage Δ
backend 55.47% <ø> (ø)
frontend 45.26% <68.18%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...harInventoryCreation/CharacterInventoryActions.tsx 25.00% <50.00%> (-9.85%) ⬇️
src/components/GoalTimeline/GoalsActions.tsx 77.77% <90.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f43f8...e49dc46. Read the comment docs.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 7f06e93 into master Jan 19, 2021
@imnasnainaec imnasnainaec deleted the goal-charinv-exchange branch January 19, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants