Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allowing user to change email #959

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Fix allowing user to change email #959

merged 2 commits into from
Jan 29, 2021

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Jan 29, 2021

Closes #951

Also:

  • Update signature of getCurrentUser() to return undefined to match style guide

This change is Reviewable

@johnthagen johnthagen added bug Something isn't working frontend labels Jan 29, 2021
@johnthagen johnthagen self-assigned this Jan 29, 2021
@codecov-io
Copy link

codecov-io commented Jan 29, 2021

Codecov Report

Merging #959 (e4b664a) into master (c8dcb13) will not change coverage.
The diff coverage is 40.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #959   +/-   ##
=======================================
  Coverage   49.83%   49.83%           
=======================================
  Files         230      230           
  Lines        6486     6486           
  Branches      403      403           
=======================================
  Hits         3232     3232           
  Misses       2953     2953           
  Partials      301      301           
Flag Coverage Δ
backend 55.47% <ø> (ø)
frontend 43.79% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/backend/localStorage.tsx 61.90% <0.00%> (ø)
src/components/UserSettings/UserSettings.tsx 0.00% <0.00%> (ø)
src/components/Login/AuthHeaders.tsx 75.00% <100.00%> (ø)
src/components/Login/LoginActions.tsx 58.49% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8dcb13...e4b664a. Read the comment docs.

@johnthagen johnthagen marked this pull request as ready for review January 29, 2021 15:28
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 8 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@johnthagen johnthagen merged commit 6d86398 into master Jan 29, 2021
@johnthagen johnthagen deleted the fix-email-chagen branch January 29, 2021 15:41
@imnasnainaec imnasnainaec removed their request for review January 29, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User cannot change/correct his/her e-mail address
3 participants