-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused exports. #977
Conversation
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
==========================================
- Coverage 50.07% 44.04% -6.04%
==========================================
Files 236 195 -41
Lines 6482 3106 -3376
Branches 394 394
==========================================
- Hits 3246 1368 -1878
+ Misses 2945 1447 -1498
Partials 291 291
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I used https://www.npmjs.com/package/ts-unused-exports to find these. There are a handful of unused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 66 of 66 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/types/goals.tsx, line 95 at r1 (raw file):
return Math.floor(Math.random() * 9999999).toString();
We need to make a note to replace this with a true guid, from a uuid library or some other well used and well maintained guid library.
|
Also remove unused component localization and sort import in some of the files.
This change is