Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused exports. #977

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Remove unused exports. #977

merged 3 commits into from
Feb 4, 2021

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 3, 2021

Also remove unused component localization and sort import in some of the files.


This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Feb 3, 2021
@imnasnainaec imnasnainaec self-assigned this Feb 3, 2021
@codecov-io
Copy link

Codecov Report

Merging #977 (57748b8) into master (d120d05) will decrease coverage by 6.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
- Coverage   50.07%   44.04%   -6.04%     
==========================================
  Files         236      195      -41     
  Lines        6482     3106    -3376     
  Branches      394      394              
==========================================
- Hits         3246     1368    -1878     
+ Misses       2945     1447    -1498     
  Partials      291      291              
Flag Coverage Δ
backend ?
frontend 44.04% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/AppBar/AppBarComponent.tsx 100.00% <ø> (ø)
src/components/Buttons/FileInputButton.tsx 20.00% <ø> (ø)
src/components/ContextMenu/ContextMenu.tsx 90.00% <ø> (ø)
.../DataEntry/DataEntryTable/NewEntry/SenseDialog.tsx 14.28% <ø> (ø)
...s/DataEntry/DataEntryTable/NewEntry/VernDialog.tsx 71.42% <ø> (ø)
...nts/GoalTimeline/GoalDisplay/HorizontalDisplay.tsx 10.00% <ø> (ø)
...nents/GoalTimeline/GoalDisplay/VerticalDisplay.tsx 76.92% <ø> (ø)
.../GoalTimeline/GoalHistory/GoalHistoryComponent.tsx 50.00% <ø> (ø)
src/components/GoalTimeline/GoalHistory/index.tsx 100.00% <ø> (ø)
...eline/GoalSuggestions/GoalSuggestionsComponent.tsx 100.00% <ø> (ø)
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d120d05...57748b8. Read the comment docs.

@imnasnainaec
Copy link
Collaborator Author

I used https://www.npmjs.com/package/ts-unused-exports to find these. There are a handful of unused exports I didn't remove because I thought they could use unit tests, so future use of ts-unused-exports can nudge that way.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 66 of 66 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/types/goals.tsx, line 95 at r1 (raw file):

return Math.floor(Math.random() * 9999999).toString();

We need to make a note to replace this with a true guid, from a uuid library or some other well used and well maintained guid library.

@imnasnainaec
Copy link
Collaborator Author

Reviewed 66 of 66 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

src/types/goals.tsx, line 95 at r1 (raw file):

return Math.floor(Math.random() * 9999999).toString();

We need to make a note to replace this with a true guid, from a uuid library or some other well used and well maintained guid library.

#984

@imnasnainaec imnasnainaec merged commit 9d9806e into master Feb 4, 2021
@imnasnainaec imnasnainaec deleted the remove-unused-exports branch February 4, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants